Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote start/stop using RFID #14

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add remote start/stop using RFID #14

merged 3 commits into from
Dec 1, 2023

Conversation

fekberg
Copy link
Contributor

@fekberg fekberg commented Dec 1, 2023

Allow Remote Start/Stop using RFID which is a requirement if OCPP is enabled.

Endpoints: PUT
/api/v4/chargepoints/{chargePointId}/connectors/{connectorId}/remotestart
Re

PUT
/api/v4/chargepoints/{chargePointId}/connectors/{connectorId}/remotestop

Copy link
Member

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, some minor changes and we're good.

chargeamps/external.py Outdated Show resolved Hide resolved
chargeamps/base.py Show resolved Hide resolved
chargeamps/external.py Outdated Show resolved Hide resolved
@fekberg fekberg requested a review from jschlyter December 1, 2023 12:38
@jschlyter
Copy link
Member

@fekberg poetry run isort . ; poetry run black .

@fekberg
Copy link
Contributor Author

fekberg commented Dec 1, 2023

@jschlyter Thanks, that helps! Been out of the python game for quite some time, apologize!

@jschlyter jschlyter merged commit 4a8e796 into kirei:main Dec 1, 2023
4 checks passed
@fekberg
Copy link
Contributor Author

fekberg commented Dec 1, 2023

@jschlyter Maybe you can shed some light on this. I'm getting a 403 FORBIDDEN only for remote_stop. Running the exact same PUT request in postman gives me either 200 OK or 400 BAD REQUEST (depending on if there is an active session or not)

Did I do something wrong invoking PUT? Wondering if the auth token wasnt provided if there is no payload, or something in those lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants