From 2bea33533fffb6459b063794df06f176a6e2ecea Mon Sep 17 00:00:00 2001
From: kirides <john.heckendorf@outlook.com>
Date: Fri, 5 Jan 2024 15:18:45 +0100
Subject: [PATCH] pipeline: update build.yml dependencies, fix missing artifact

---
 .github/workflows/build.yml | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 681f10bf..7b61231b 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -40,7 +40,7 @@ jobs:
       run: msbuild /p:Configuration=${{matrix.configuration}} .
       
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ matrix.configuration }}
         path: ${{ matrix.configuration }}/ddraw.dll
@@ -62,10 +62,10 @@ jobs:
         echo "RELEASE_VERSION=${tagName}" >> $Env:GITHUB_ENV
         echo "RELEASE_DIR=${dirName}" >> $Env:GITHUB_ENV
 
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
     
     - name: Display structure of downloaded files
-      run: ls -R
+      run: tree
     
     - name: Create distribution
       working-directory: ${{env.GITHUB_WORKSPACE}}
@@ -84,10 +84,12 @@ jobs:
         copy "Launcher\ddraw.dll" "${{env.RELEASE_DIR}}\"
     
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ env.RELEASE_DIR }}
         path: ${{ env.RELEASE_DIR }}
+        # higher values don't get us much due to DLLs, libs, textures...
+        compression-level: 1
 
     - name: zip distribution for nightly
       if: github.ref_name == 'master'
@@ -110,25 +112,18 @@ jobs:
       with:
         delete_release: true
         tag_name: nightly
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        github_token: ${{ secrets.GITHUB_TOKEN }}
 
     - name: Create new nightly
       if: github.ref_name == 'master'
+      # v1.13.0
       uses: ncipollo/release-action@6c75be85e571768fa31b40abf38de58ba0397db5
       with:
         name: Nightly
         generateReleaseNotes: true
         prerelease: true
         draft: false
-        artifacts: "${{env.RELEASE_DIR}}.zip,{{env.RELEASE_DIR}}.zip.sha256"
+        omitDraftDuringUpdate: true
+        artifacts: "${{env.RELEASE_DIR}}.zip,${{env.RELEASE_DIR}}.zip.sha256"
         tag: nightly
         token: ${{ secrets.GITHUB_TOKEN }}
-
-    - name: Un-Draft Nightly
-      if: github.ref_name == 'master'
-      run: |
-        gh release edit ${{env.RELEASE_VERSION}} --draft=false
-        exit 0
-      env:
-        GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}