-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Exception in HostFunction: expected 1 arguments, got 0 #429
Comments
@kirillzyusko is there any eta for react native 0.74 ? |
Hello @edapess I was working in this branch for support 0.74 - https://github.com/kirillzyusko/react-native-keyboard-controller/pull/410/files And I managed to run both apps (paper/fabric) without significant code modifications 🤷♂️ Can you try to use the version from this branch and see if it fixes the problem? |
@kirillzyusko you mean |
@edapess I meant to try to use |
@kirillzyusko I tried but it's not working, I think the issue can be related to reanimated version that we have to use in our app.
Any Idea? Also I found this PR #410 |
Yes @edapess Can you try to use a version from the PR you sent? In this PR I'm using REA 3.9.0 so we both should use the same version 😊 |
@kirillzyusko I tried again, nothing changed, so the error comes from |
Interesting 🤔 What is the version of REA in |
@edapess it's weird 🤔 Why everything works in my PR? I'm also using |
@kirillzyusko yeeeah, it's weird :////, there is many reports |
## 📜 Description Updated `react-native` to `0.74` (wich has bridgeless mode enabled by default in new arch). ## 💡 Motivation and Context We need to support bridgeless mode. Main changes to make fabric working were: - change a context from which we emit an event (event emitter, not dispatcher); - remove checks for `_jsThread` on iOS (since it's bridgeless mode -> these variable will be always `false`); Also in this PR I had to remove flipper integration to speed up delivery of this PR. Later on I'll probably add this integration back. Closes #429 #394 ## 📢 Changelog ### JS - bumed deps; ### iOS - removed `_jsThread` check as in Fabric it'll be always `false`; ### Android - change context for emitting events (now we need to use appContext); ## 🤔 How Has This Been Tested? tested locally + on CI using both architectures. ## 📸 Screenshots (if appropriate): Everything works as before 🙃 ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Well, I merged a pr with bridgeless support into Let's keep this PR open for now. If you want - you can clone this repository and compare project settings with your own project 👀 Maybe it'll help you somehow (but basically everything should be working). |
@kirillzyusko Thanks anyway, will try, and will get back here if i find something, maybe it will help somebody else |
Sometimes I get exactly this error, but in React Native 0.73 and reanimated 3.8 and latest version keyboard-controller. It's hard to say what's wrong because the error appears randomly, only on Android. |
Hey @irekrog @kirillzyusko I found the problem, in our app we had reanimated in resolutions section, so there was 3.6.1 version, which causes the problem, so check that case. Hope this will help you. So now my reanimated is 3.9.0 and react native is 0.74.0, everything works fine I had to remove or bump version in resolutions, then delete node modules and install again. |
FYI in my case there was a problem with react-native-code-push :) |
Describe the bug
App crashes after start
To Reproduce
Update react native to 0.74.0
Screenshots
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: