Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All processes selection should be possible for one or all table pages #3747

Closed
matthias-ronge opened this issue Jun 9, 2020 · 4 comments · Fixed by #4722
Closed

All processes selection should be possible for one or all table pages #3747

matthias-ronge opened this issue Jun 9, 2020 · 4 comments · Fixed by #4722
Assignees
Labels

Comments

@matthias-ronge
Copy link
Collaborator

If you click on Checkbox button all pages selection, it is not clear whether all hits in the page are selected or on all pages. (Right now, it's the former.) For Kitodo script applications, the latter should also be important.

Screenshot of select-all check box

Suggestion: When the checkbox is checked, if it has more than one table page, a selection with options appears: all hits on this page, entire hit set.

Example (small):

Example 1

Example (large):

Example 2

@matthias-ronge
Copy link
Collaborator Author

Just thinking: JSF supports three-state checkboxes: They can be unchecked, semi-checked or checked. Could also be implemented as: If no process is selected, clicking the select-all checkbox turns it semi-checked, and all processes currently visible are checked. If some processes are selected (may also be happened manually) the checkbox shows semi-checked, and clicking it in this state selects all hits from the search. If all hits are selected, the checkbox is checked, and clicking the checkbox deselects all. This would prevent menus, which may be found annoying.

@andre-hohmann
Copy link
Collaborator

I like your suggestion with the menu to select "Alle Treffer dieser Seite" and "Gesamtes Trefferset". It it easily understandable and the risk of misinterpretation is very low.

@markusweigelt
Copy link
Collaborator

markusweigelt commented Sep 29, 2021

@andre-hohmann Is the selection "Alle Treffer dieser Seite" used, or you can generally switch here so that the "Gesamtes Trefferset" can always be selected with the available checkbox. The problem with behavior is, it should be used everywhere
and possibly there are cases where the selection "Alle Treffer dieser Seite" is used.

@matthias-ronge I thought the tri-state checkbox is a good idea, but is not directly possible for Primeface DataTables. However, we could implement such a checkbox here using JavaScript.

image

@andre-hohmann Do you still prefer the dropdown or is the tri-state checkbox a good idea?

@andre-hohmann
Copy link
Collaborator

I use mostly "Gesamtes Trefferset", but i can imagine, that other users also use "Alle Treffer dieser Seite". Unfortunately, we have often the problem, that we cannot estimate the behaviour of all users. I suggest to offer both options, if it is possible.

I prefer the drop down-option, because it is clear for everyone, what will happen. The checkboxes can be misinterpreted without any explanation.

markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 5, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 6, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 8, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 8, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 8, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 15, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 15, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Oct 15, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 15, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 22, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 22, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 22, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 22, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 22, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 22, 2021
markusweigelt added a commit to markusweigelt/kitodo-production that referenced this issue Nov 22, 2021
Kathrin-Huber added a commit that referenced this issue Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants