Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the drop-down with the current task in the correction message? #4157

Closed
matthias-ronge opened this issue Jan 19, 2021 · 2 comments
Closed
Labels

Comments

@matthias-ronge
Copy link
Collaborator

When creating a correction message, a drop-down is offered in which the current task is displayed and selected. There are no alternatives to choose from here either. In which constellation is this selection significant?

a drop-down with the current task

@solth
Copy link
Member

solth commented Jan 19, 2021

The current implementation of "Correction comments" requires a "correction task" (to which the workflow jumps back) and a "current task" (to which the workflow returns once the correction has been completed).

Kitodo.Production 2 only supported strictly sequential lists of tasks in a process. Therefore, it was unambiguous which task was the "current" task at any given moment. But since Kitodo.Production 3 supports workflows with parallel tasks, it is now possible to have multiple tasks open or in work at the same time.

When opening a process from the Current Task Details page, the current task is self-explanatory - which is then preset as the "Current task" in the pulldown menu of the popup, btw - no matter how many parallel tasks might exist.

When opening a process with multiple "open" or "inwork" tasks in the metadata editor from the Process List however, it is not clear which of those parallel tasks is the "Current task", which is why we need the pulldown menu in the popup dialog.

Maybe this is an edge case, but it needs to be supported nonetheless (we already had such cases!)

Perhaps it would be a good solution to always deactivate the pulldown menu for "Current task" if there is only one option anyway (with an explanatory tooltip)?

@matthias-ronge
Copy link
Collaborator Author

So, current task is meant as “after the correction task, return to…”?

If it is this, it makes a lot of sense and then it should offer all possibilities after the task selected as correction task, up to and including the current task. If this is how it is meant, the box should be relabeled (i.e. "after correction, return to") and I would also suggest to put it below the “correction task” select then. (In 2.x, I think the person who performed the correction task had possibility to select where to continue when finishing the correction task. But I am not sure. However, he or she needs to know, so it feels to me that the 3.x solution is better.)

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

2 participants