Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate "Save" button in metadata editor until data changes #4438

Open
solth opened this issue May 27, 2021 · 4 comments
Open

Deactivate "Save" button in metadata editor until data changes #4438

solth opened this issue May 27, 2021 · 4 comments

Comments

@solth
Copy link
Member

solth commented May 27, 2021

Similar to how the "Save" button is deactivated on "Project edit", "User edit" etc. pages until the some data has been changed by the user, the "Save" button in the metadata editor should also be deactivated until there is something to save (as an indication to the user that there are unsaved changes)

@matthias-ronge
Copy link
Collaborator

Note that there may be changes that occur when the metadata editor is started, namely when new images have been found and inserted into the workpiece. In that case you should be able to save immediately. Just to mention it.

@andre-hohmann
Copy link
Collaborator

I can support @matthias-ronge hint.
The feature is "Read in pagination from images" which is done automatically and is absolutely necessary to write the references in the METS-file. Many users wish, that the references are written independently from the editor. If these references cannot be saved, the METS-files are incomplete.

@matthias-ronge
Copy link
Collaborator

Many users wish, that the references are written independently from the editor.

There is an issue for this: #3333

@solth
Copy link
Member Author

solth commented Jun 21, 2021

Note that there may be changes that occur when the metadata editor is started, namely when new images have been found and inserted into the workpiece. In that case you should be able to save immediately. Just to mention it.

Good point. Perhaps it would be useful to have a small info dialog in the metadata editor (or at least a growl message) when new images have been found to explicitly inform the user that there are new unsaved changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants