Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check for duplicate titles when creating the process using the process form #6303

Open
BartChris opened this issue Nov 14, 2024 · 3 comments
Labels
bug import Import mappings and configurations

Comments

@BartChris
Copy link
Collaborator

BartChris commented Nov 14, 2024

Describe the bug
There seems to be no validation for a duplicate process title happening when i use the standard way to create a new process using the CreateProcess form.

Kitodo configuration seems to be correct

# Configure whether each process needs to have a unique title or not
uniqueProcessTitles=true

When checking the code in importProcessHierarchy i see no call of processTempProcess where this validation would take place.

public LinkedList<TempProcess> importProcessHierarchy(String recordId, ImportConfiguration importConfiguration,

public static void processTempProcess(TempProcess tempProcess, RulesetManagementInterface rulesetManagement,

To Reproduce
Steps to reproduce the behavior:

  1. Create a process with title 'ABC' using the normal create process form
  2. Try to create another process with the same title 'ABC'
  3. The duplicate title is not prevented

Expected behavior
It should not be possible to create processes with duplicate titles, when the configuration disallows that.

Release
Kitodo 3.7.1, Master

@BartChris BartChris added bug import Import mappings and configurations labels Nov 14, 2024
@solth
Copy link
Member

solth commented Nov 14, 2024

I think this describes the same problem as is related to #6055

@stweil
Copy link
Member

stweil commented Nov 22, 2024

Is it necessary to avoid titles which only differ in upper/lower case? Such titles would not work on NTFS (Windows), macOS filesystems and also on some case insensitive Linux filesystem.

@henning-gerhardt
Copy link
Collaborator

Kitodo.Production is using case sensitive title generation since years (I think 1.8 oder 1.9 of the old Goobi Community edition removed the case insensitive process titles) and until now no one issue was reported from productive environments where this made a problem. The problems reported here was only from a few developers on there systems which are not able to use case sensitive names like database table names as their development OS limited them (instead of fixing or adjusting it). Please don't add the old way back as this introduce new trouble and you can not adjust already existing titles without creating more trouble everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug import Import mappings and configurations
Projects
None yet
Development

No branches or pull requests

4 participants