Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling and error message #4117

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

Kathrin-Huber
Copy link
Contributor

fix #4108

@@ -36,13 +36,7 @@
<!--@elvariable id="isViewMode" type="boolean"-->
<ui:param name="isViewMode"
value="#{not isEditMode and not isDuplicateMode and not isCreateMode and SecurityAccessController.hasAuthorityToViewWorkflow()}"/>

<ui:define name="messages">
Copy link
Member

@solth solth Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was specifically added in #3558 to prevent the same error message from being displayed twice - meaning wihtout further adjustments merging this PR will reopen the issue #3401

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this was presumably leading to #4108 so both solutions aren't really satisfactory....
I'm trying to find a way to fix both...

@Kathrin-Huber Kathrin-Huber marked this pull request as draft December 3, 2020 16:59
@Kathrin-Huber Kathrin-Huber force-pushed the fix_empty_errorMessage branch from 4259a30 to 148ebb7 Compare December 3, 2020 17:12
@Kathrin-Huber
Copy link
Contributor Author

workflowErrorMessage

Both is working now :-)

@Kathrin-Huber Kathrin-Huber marked this pull request as ready for review December 3, 2020 17:24
@solth
Copy link
Member

solth commented Dec 4, 2020

This also seems to fix #4081 and #4082

@Kathrin-Huber Kathrin-Huber merged commit 733de41 into kitodo:master Dec 4, 2020
@Kathrin-Huber Kathrin-Huber deleted the fix_empty_errorMessage branch December 4, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving a workflow without setting permissions throws empty error message
2 participants