Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returndata merged with child on call frame error #898

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Sep 3, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #896

What is the new behavior?

  • We used to always merge the returndata of a child call frame with its parent frame. Now, we only do it when the child has had an execution success
  • Needs to differentiate further between normal reverts (REVERT) and exceptional reverts with feat: differentiate betwteen REVERT opcodes an exceptional failures #897. Only in cases of exceptional reverts should this field NOT be merged with the parent's frame.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@enitrat enitrat merged commit a6fbebb into main Sep 3, 2024
4 checks passed
@enitrat enitrat deleted the fix/returndata-merged-on-error branch September 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: return_data wrongly merged with parent on exceptional revert
1 participant