Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: addmod builtin assertion fails #913

Open
enitrat opened this issue Feb 28, 2025 · 0 comments
Open

bug: addmod builtin assertion fails #913

enitrat opened this issue Feb 28, 2025 · 0 comments

Comments

@enitrat
Copy link
Collaborator

enitrat commented Feb 28, 2025

In cairo/tests/ef_tests/cancun/test_state_transition.py::test_general_state_tests[stPreCompiledContracts2 - ecrecoverShortBuff_d0g0v0_Cancun] there's an issue where when verifying the constraits on the addmod builtin, this happens:

RuntimeError: add_mod_builtin: Expected a + b == c (mod p). Got: instance=355, batch=0, p=115792089237316195423570985008687907853269984665640564039457584007908834671663, a=0, b=32935497925714090926372191887924593461814130700592960671670977223796577118717, c=0.

Which means that at some point, we're running a circuit with incorrect values.

We need to check what parameters ecrecover is called with - and what the builtin is filled with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant