Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded variables #6

Open
3 tasks
kctraveler opened this issue Jul 26, 2023 · 1 comment
Open
3 tasks

Remove hardcoded variables #6

kctraveler opened this issue Jul 26, 2023 · 1 comment

Comments

@kctraveler
Copy link
Contributor

References to local filepaths and user information:

  • sparkbadge/sparkline.py line 102 is hard coded to a location on previous project owners local disc
  • .github/workflows/test-action.yml makes a commit with previous project owners account with every push

References to repositories:

  • sparkbadge/init.py line 131 runs sparkbadge with facebook/react as the repository. Needs to be removed completely.
@kctraveler
Copy link
Contributor Author

.github/workflows/test-action.yml should probably be removed entirely until issue #7 is developed. In current form it is just going to muddy up the commit history.

sugamadhiakri added a commit to sugamadhiakri/sparkbadge that referenced this issue Oct 24, 2024
@sugamadhiakri
remove hardcoded value on issue klaeufer#6
1a2d3cd
@sugamadhiakri sugamadhiakri mentioned this issue Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kctraveler