Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Contrast for some Characters #19

Open
iameswan opened this issue Jan 5, 2025 · 0 comments
Open

Low Contrast for some Characters #19

iameswan opened this issue Jan 5, 2025 · 0 comments

Comments

@iameswan
Copy link

iameswan commented Jan 5, 2025

Description

Several character themes with light backgrounds (yellow, beige, sandy) have light-colored text, creating significant contrast and readability issues. This affects:

  1. Finn (yellow background #FDC733 with white text #FEFEFE)
  2. Leia Organa (yellow background #FDE663 with white text #FEFEFE)
  3. Princess Leia (yellow background #F9E163 with white text #FEFEFE)
  4. Rey (light brown background #887D73 with purple text #2D0042)
  5. Maz Kanata (sandy background #EDDCB2 with white text #F9F9FA)

Steps to reproduce

  1. Install hyper-star-wars theme
  2. Set character to any of the above characters (or use random until they appear)
  3. Notice the poor text contrast, especially when typing commands

Proposed solution

Change the font color to black (#000000) for these specific characters to improve readability while maintaining their distinctive background colors.

Theme settings

js
StarWarsTheme: {
character: 'random', // or any specific character listed above
lightsaber: 'true',
unibody: 'false',
avatar: 'true'
}

Environment

  • Hyper version: 3.4.1
  • OS: macOS 24.1.0
  • Theme version: 3.2.1

I have a working fix ready to submit as a PR once this issue is acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant