You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several character themes with light backgrounds (yellow, beige, sandy) have light-colored text, creating significant contrast and readability issues. This affects:
Finn (yellow background #FDC733 with white text #FEFEFE)
Leia Organa (yellow background #FDE663 with white text #FEFEFE)
Princess Leia (yellow background #F9E163 with white text #FEFEFE)
Rey (light brown background #887D73 with purple text #2D0042)
Maz Kanata (sandy background #EDDCB2 with white text #F9F9FA)
Steps to reproduce
Install hyper-star-wars theme
Set character to any of the above characters (or use random until they appear)
Notice the poor text contrast, especially when typing commands
Proposed solution
Change the font color to black (#000000) for these specific characters to improve readability while maintaining their distinctive background colors.
Theme settings
js
StarWarsTheme: {
character: 'random', // or any specific character listed above
lightsaber: 'true',
unibody: 'false',
avatar: 'true'
}
Environment
Hyper version: 3.4.1
OS: macOS 24.1.0
Theme version: 3.2.1
I have a working fix ready to submit as a PR once this issue is acknowledged.
The text was updated successfully, but these errors were encountered:
Description
Several character themes with light backgrounds (yellow, beige, sandy) have light-colored text, creating significant contrast and readability issues. This affects:
#FDC733
with white text#FEFEFE
)#FDE663
with white text#FEFEFE
)#F9E163
with white text#FEFEFE
)#887D73
with purple text#2D0042
)#EDDCB2
with white text#F9F9FA
)Steps to reproduce
character
to any of the above characters (or userandom
until they appear)Proposed solution
Change the font color to black (
#000000
) for these specific characters to improve readability while maintaining their distinctive background colors.Theme settings
js
StarWarsTheme: {
character: 'random', // or any specific character listed above
lightsaber: 'true',
unibody: 'false',
avatar: 'true'
}
Environment
I have a working fix ready to submit as a PR once this issue is acknowledged.
The text was updated successfully, but these errors were encountered: