From 6c8475c93d80b8bf638be998139981d267e6ec43 Mon Sep 17 00:00:00 2001
From: Shubham Parkhi <shubhamparkhi10@gmail.com>
Date: Tue, 21 May 2024 04:45:13 +0530
Subject: [PATCH] refactor(web): Error handling logic

---
 .../Courts/CourtDetails/StakePanel/InputDisplay.tsx    | 10 ++--------
 .../CourtDetails/StakePanel/StakeWithdrawButton.tsx    |  9 +--------
 2 files changed, 3 insertions(+), 16 deletions(-)

diff --git a/web/src/pages/Courts/CourtDetails/StakePanel/InputDisplay.tsx b/web/src/pages/Courts/CourtDetails/StakePanel/InputDisplay.tsx
index 479bbb2a4..e8ac27289 100644
--- a/web/src/pages/Courts/CourtDetails/StakePanel/InputDisplay.tsx
+++ b/web/src/pages/Courts/CourtDetails/StakePanel/InputDisplay.tsx
@@ -68,7 +68,6 @@ const InputDisplay: React.FC<IInputDisplay> = ({
   setAmount,
 }) => {
   const [debouncedAmount, setDebouncedAmount] = useState("");
-  const [hasInteracted, setHasInteracted] = useState(false);
   const [errorMsg, setErrorMsg] = useState<string | undefined>();
   useDebounce(() => setDebouncedAmount(amount), 500, [amount]);
   const parsedAmount = useParsedAmount(uncommify(debouncedAmount) as `${number}`);
@@ -90,7 +89,7 @@ const InputDisplay: React.FC<IInputDisplay> = ({
   const isStaking = useMemo(() => action === ActionType.stake, [action]);
 
   useEffect(() => {
-    if (!hasInteracted || parsedAmount === 0n) {
+    if (parsedAmount === 0n) {
       setErrorMsg(undefined);
     } else if (isStaking && balance && parsedAmount > balance) {
       setErrorMsg("Insufficient balance to stake this amount");
@@ -99,7 +98,7 @@ const InputDisplay: React.FC<IInputDisplay> = ({
     } else {
       setErrorMsg(undefined);
     }
-  }, [hasInteracted, parsedAmount, isStaking, balance, jurorBalance]);
+  }, [parsedAmount, isStaking, balance, jurorBalance]);
 
   return (
     <>
@@ -109,7 +108,6 @@ const InputDisplay: React.FC<IInputDisplay> = ({
           onClick={() => {
             const amount = isStaking ? parsedBalance : parsedStake;
             setAmount(amount);
-            setHasInteracted(true);
           }}
         >
           {isStaking ? "Stake" : "Withdraw"} all
@@ -121,7 +119,6 @@ const InputDisplay: React.FC<IInputDisplay> = ({
             value={uncommify(amount)}
             onChange={(e) => {
               setAmount(e);
-              setHasInteracted(true);
             }}
             placeholder={isStaking ? "Amount to stake" : "Amount to withdraw"}
             message={errorMsg ?? undefined}
@@ -137,9 +134,6 @@ const InputDisplay: React.FC<IInputDisplay> = ({
                 isSending,
                 setIsSending,
                 setIsPopupOpen,
-                setErrorMsg,
-                hasInteracted,
-                setHasInteracted,
               }}
             />
           </EnsureChainContainer>
diff --git a/web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx b/web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx
index f9249de27..3644d21f2 100644
--- a/web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx
+++ b/web/src/pages/Courts/CourtDetails/StakePanel/StakeWithdrawButton.tsx
@@ -34,9 +34,6 @@ interface IActionButton {
   setIsSending: (arg0: boolean) => void;
   setAmount: (arg0: string) => void;
   setIsPopupOpen: (arg0: boolean) => void;
-  setErrorMsg: (arg0: string | undefined) => void;
-  hasInteracted: boolean;
-  setHasInteracted: (arg0: boolean) => void;
 }
 
 const StakeWithdrawButton: React.FC<IActionButton> = ({
@@ -45,7 +42,6 @@ const StakeWithdrawButton: React.FC<IActionButton> = ({
   isSending,
   setIsSending,
   setIsPopupOpen,
-  setHasInteracted,
 }) => {
   const { id } = useParams();
   const { address } = useAccount();
@@ -149,10 +145,7 @@ const StakeWithdrawButton: React.FC<IActionButton> = ({
           (targetStake !== 0n && targetStake < BigInt(courtDetails.court?.minStake)) ||
           (isStaking && !isAllowance && isUndefined(setStakeConfig.request))
         }
-        onClick={() => {
-          setHasInteracted(true);
-          onClick();
-        }}
+        onClick={onClick}
       />
     </EnsureChain>
   );