Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dApps dropdown, added docs/about styles, asking to remove clg #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abhiram11
Copy link

This PR tries to fix a UI bug that happens between screen sizes 768px to 992px. It also adds a few styling attributes in CSS that were supposedly missing for docs and about dropdowns.

Here's how it looked before:

kleros.old.mp4

Here's how it looks after the fix:

kleros.new.mp4

Before merging, I would like to have your review on the things below:

  1. How should the dropdown's arrow icon react to clicks/collapse? I have edited the styling for dApps for your reference.
  2. Should the style className IDs be different for .usecases, .research, .governance, .docs, .about, etc. ? As they are displayed in a similar fashion, we can define just one class style for them.
  3. If the console.log() are not required in index.js, I can remove them as well.
  4. There were empty rulesets in the CSS file that I have modified, let me know what to do about them.

Thanks! : )

@netlify
Copy link

netlify bot commented Apr 6, 2023

👷 Deploy request for kleros-website pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5c885a6

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant