-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support one order for all bidders (no PREBID_BIDDER_CODE) #18
Comments
I agree that this would be a good improvement. If we add this, I'd like to generalize the key-value targeting. Right now, we call |
Agreed, this would be helpful/major time and complexity savor. |
I would like this too. Has someone managed to modify this such that hb_bidder is not required? |
Quick & dirty workaround: Within create_line_items.py, changed the logicalOperator to OR and children criteria both as hp_pb
This looks silly, but got the desired results in DFP. |
I'd love to see how I can change this behavior too. I did what @sujithvn mentioned above but it didn't seem to work as it threw an error. Anyway I can modify this tool to accept multiple BidderCodes or none? The normal behavior of Prebid is to accept multiple bidders and not to be only associated with only one (ex. AppNexus, Sovrn, IndexExchange, Rubicon, etc). Any help would be greatly appreciated. |
Did anyone find another workaround they can share? |
In the case of not wanting to have one order per bidder rather using a global one by just targeting hb_pb we should allow a None PREBID_BIDDER_CODE
Same approach is recommended in the video tutorial how to setup prebid in DFP http://prebid.org/adops/step-by-step.html
The text was updated successfully, but these errors were encountered: