Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: missing logout link #2143

Open
diginote opened this issue Nov 8, 2024 · 4 comments
Open

OIDC: missing logout link #2143

diginote opened this issue Nov 8, 2024 · 4 comments
Labels
question Further information is requested

Comments

@diginote
Copy link

diginote commented Nov 8, 2024

Version:

  • listmonk: v4.0.1
  • OS: official container image

Description of the bug and steps to reproduce:
No Logout URL definition for OAuth-Providers (OIDC). When user click logout you need to call a link of the OAuth-Provider with a redirect to the domain where listmonk is accessable. Currently listmonk do not have an option to define an logout URL in the OIDC SSO settings und the logout is only locally. The session on the OAuth-Provider is not closed. Therfore you are not really logged out. When you click on the login button the next time you will be redirected to the OIDC-Provider where your session is active und you will be immediately redirected to listmonk again without an input of your credentials.

Expected behavior
When I logout you have to call the OAuth-Provider endpoint with a redirect url to listmonk domain. For that you need to define that endpoint in the OIDC SSO settings. Currently there is no such setting and the logout link is wrong when you use OIDC.

More information here:

@diginote diginote added the bug Something isn't working label Nov 8, 2024
@knadh
Copy link
Owner

knadh commented Nov 10, 2024

When you click on the login button the next time you will be redirected to the OIDC-Provider where your session is active und you will be immediately redirected to listmonk again without an input of your credentials.

Are you referring the session on the OIDC provider (eg: Google) being active? It is very unusual for an oAuth application to sign the user out of the OAuth provider and all sessions. I haven't seen this in action anywhere. I can see that the spec has been added recently, but this isn't a bug. Can you cite some examples of applications that support this?

@knadh knadh added question Further information is requested and removed bug Something isn't working labels Nov 10, 2024
@diginote
Copy link
Author

Yes, I mean the session on the OIDC provider. It's like a single sign-on where I only have to sign in once. Single sign-out means that I don't have to log in every application. It is enough if I log out in one application. See here example: single sign-out: https://developers.redhat.com/articles/2022/12/07/how-implement-single-sign-out-keycloak-spring-boot

Our users were irritated that they were logged in again after logging out without entering their access data. The question was: How can we really logout?

@kosssi
Copy link
Contributor

kosssi commented Nov 12, 2024

I thinks it's a good feature. Non-technical users can't understand why when they clic on logout it's not really logout ;)

I used this softwares which implement this:

I find it important for security ;)

@knadh
Copy link
Owner

knadh commented Nov 13, 2024

That's very helpful @kosssi.

listmonk uses the coreos/go-oidc package. Looks like it does not support backchannel logout yet: coreos/go-oidc#211

Let me comment on the issue there and see 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants