The committers listed above are authorized under a signed CLA.

• ✅ login: prakhar479 / name: Prakhar Singhal (32929c7, 46fdb5a, b39eebd, 62ba7b2, 4909b5d)

Welcome @prakhar479! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉

Hi @prakhar479. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prakhar479
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

/cc @Leo6Leo @Cali0707

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.48%. Comparing base (e9ac303) to head (4909b5d).
Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main    #4028   +/-   ##
=======================================
  Coverage   48.48%   48.48%           
=======================================
  Files         244      244           
  Lines       14469    14469           
=======================================
  Hits         7016     7016           
  Misses       6746     6746           
  Partials      707      707           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seems like the java tests are failing. I found following as first point of failure:

Running dev.knative.eventing.kafka.broker.core.file.FileWatcherTest

with error:

Error:  Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.68 s <<< FAILURE! -- in dev.knative.eventing.kafka.broker.core.file.FileWatcherTest

these were some relevant logs between initialization and error:

09:06:16.244 [contract-file-watcher] INFO  dev.knative.eventing.kafka.broker.core.file.FileWatcher - Started watching /tmp/test5718446383111542373.txt
09:06:16.267 [contract-file-watcher] DEBUG dev.knative.eventing.kafka.broker.core.file.FileWatcher - Contract updates
09:06:16.284 [contract-file-watcher] DEBUG dev.knative.eventing.kafka.broker.core.file.FileWatcher - Contract updates
09:06:26.325 [contract-file-watcher] INFO  dev.knative.eventing.kafka.broker.core.file.FileWatcher - Started watching /tmp/test654706480592262681.txt

Can someone help with following since I did not make any changes to core logic and thus am unsure why are these failing. thanks!

emm, this flaky test appears again. That's a separate issue, and this is not related to your PR @prakhar479 .

I will look into this and get back to you, thanks for providing the clear description of the error logs!

Fix for the flaky test is here #4029

/ok-to-test

/retest

/retest-required

@pierDipi @Leo6Leo I have re-ran all tests. let me know if anything else is required. Thanks!

Thanks for starting on this @prakhar479 !

Could you also add this to

eventing-kafka-broker/test/presubmit-tests.sh

Lines 35 to 38 in dcb704a

	function build_tests() {
	header "Running control plane build tests"
	default_build_test_runner || fail_test "Control plane build tests failed"
	}

so that it gets verifies by the blocking test jobs as well as the non-blocking Java unit test you've added it to so far?

I have added the formatting check in build_tests as well.

@prakhar479: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Your PR dashboard.

I am not quite able to understand why the reconciler-tests are failing. Following error in TestKafkaChannelOIDC/KafkaChannel_handles_requests_with_OIDC_tokens_correctly/KafkaChannel_reject_event_for_wrong_OIDC_audience/Assert/KafkaChannel_get_401_on_response denotes a internal error:

- Match errors -
        0 - event status code don't match. Expected: '401', Actual: '0'
        1 - event status code don't match. Expected: '401', Actual: '0'
        2 - event status code don't match. Expected: '401', Actual: '0'
        3 - event status code don't match. Expected: '401', Actual: '500'

and both failed tests return with code 255. I am not quite sure what causes the error. What am I missing @pierDipi @Leo6Leo @Cali0707 ?

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.