Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JBoss logging from dependencies #3997

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Remove JBoss logging from dependencies #3997

merged 2 commits into from
Jul 22, 2024

Conversation

pierDipi
Copy link
Member

I don't think we need it and it might be the cause of #3901

Fixes #3901

Proposed Changes

  • Remove JBoss logging from dependencies

Release Note

Docs

pierDipi added 2 commits July 22, 2024 10:02
@pierDipi
Remove JBoss Logmanager from dependencies
1cf8a00 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi
Remove jboss-logging
fdd101d 
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/data-plane size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2024
@knative-prow knative-prow bot requested review from aliok and Leo6Leo July 22, 2024 08:07
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.15%. Comparing base (481d3fe) to head (fdd101d).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3997   +/-   ##
=======================================
  Coverage   48.15%   48.15%           
=======================================
  Files         246      246           
  Lines       14517    14517           
=======================================
  Hits         6990     6990           
  Misses       6821     6821           
  Partials      706      706

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi pierDipi changed the title [WIP] Remove JBoss logging from dependencies Remove JBoss logging from dependencies Jul 22, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
@pierDipi
Copy link
Member Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi pierDipi mentioned this pull request Jul 22, 2024
Open
@pierDipi
Copy link
Member Author

/cc @matzew @Cali0707

@knative-prow knative-prow bot requested review from Cali0707 and matzew July 22, 2024 15:27
Cali0707
Cali0707 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data plane logs are still present with these changes

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7764ab7 into knative-extensions:main Jul 22, 2024
33 checks passed
@knative-prow-robot
Copy link
Contributor

@pierDipi: #3997 failed to apply on top of branch "release-1.14":

Applying: Remove JBoss Logmanager from dependencies
Using index info to reconstruct a base tree...
M	data-plane/THIRD-PARTY.txt
M	data-plane/core/pom.xml
Falling back to patching base and 3-way merge...
Auto-merging data-plane/core/pom.xml
Auto-merging data-plane/THIRD-PARTY.txt
CONFLICT (content): Merge conflict in data-plane/THIRD-PARTY.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove JBoss Logmanager from dependencies
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@aliok aliok Awaiting requested review from aliok

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@matzew matzew Awaiting requested review from matzew

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kafka-broker-receiver crashes on startup starting with 1.14.0 in EKS
3 participants
@pierDipi @knative-prow-robot @Cali0707