Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KafkaSource v1 API #4130

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 9, 2024

Part of #3953

Proposed Changes

Release Note

Add KafkaSource v1 API

Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2024
@knative-prow knative-prow bot requested review from aliok and Cali0707 October 9, 2024 14:38
@pierDipi
Copy link
Member Author

pierDipi commented Oct 9, 2024

Boilerplate errors, I think I will ignore them, too many files that are copy-pasted need to be changed

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 3.11077% with 1277 lines in your changes missing coverage. Please review.

Project coverage is 45.15%. Comparing base (0925c8c) to head (afecd7b).

Files with missing lines Patch % Lines
...on/reconciler/sources/v1/kafkasource/reconciler.go 0.00% 164 Missing ⚠️
...trol-plane/pkg/apis/bindings/v1/kafka_lifecycle.go 0.00% 135 Missing ⚠️
...lientset/versioned/typed/sources/v1/kafkasource.go 0.00% 126 Missing ⚠️
...entset/versioned/typed/bindings/v1/kafkabinding.go 0.00% 103 Missing ⚠️
...on/reconciler/sources/v1/kafkasource/controller.go 0.00% 69 Missing ⚠️
...ersioned/typed/sources/v1/fake/fake_kafkasource.go 0.00% 66 Missing ⚠️
...ntrol-plane/pkg/apis/sources/v1/kafka_lifecycle.go 0.00% 59 Missing ⚠️
...sioned/typed/bindings/v1/fake/fake_kafkabinding.go 0.00% 54 Missing ⚠️
...plane/pkg/apis/sources/v1beta1/kafka_conversion.go 0.00% 46 Missing ⚠️
...lane/pkg/apis/bindings/v1beta1/kafka_conversion.go 0.00% 45 Missing ⚠️
... and 36 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4130      +/-   ##
==========================================
- Coverage   48.89%   45.15%   -3.75%     
==========================================
  Files         232      270      +38     
  Lines       14680    15985    +1305     
==========================================
+ Hits         7178     7218      +40     
- Misses       6779     8041    +1262     
- Partials      723      726       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi
Copy link
Member Author

/retest-required

@pierDipi pierDipi changed the title [WIP] Add KafkaSource v1 API Add KafkaSource v1 API Oct 11, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
@pierDipi
Copy link
Member Author

/cc @creydr @matzew @aliok

@knative-prow knative-prow bot requested review from creydr and matzew October 11, 2024 06:24
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for driving this, and yes lot's of copy-pasta here.

LGTM!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link

knative-prow bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

/retest-required

@knative-prow knative-prow bot merged commit 024dd1f into knative-extensions:main Oct 14, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants