TestResolveAddress should allow overriding test image

[mgencur]

The test is located here and it consumes test cases defined in pkg/k8s/test/addressresolver_cases.go.
The test case hardcodes the gcr.io/knative-samples/helloworld-go image which is not multiarch.
We would like to be able to define TEST_IMAGES_HELLOWORLD_GO env variable to override the image. The image resolver should be able to replace the hardcoded one with the one define via env variable. This way we could pass a multiarch version of that image, for example.

Similar approach is used for other E2E tests, for example the wathola-forwarder image can be overridden via env variable TEST_IMAGES_WATHOLA_FORWARDER: link

The TestResolveAddress test is the only E2E test which doesn't allow overriding the test image.

[cardil]

@mgencur The gcr.io/knative-samples/helloworld-go is provided from the Serving sources, right? We should open up an issue there to make it multi-arch.

[cardil]

@mgencur The gcr.io/knative-samples/helloworld-go is provided from the Serving sources, right? We should open up an issue there to make it multi-arch.

Scratch that. Those images are provided from docs repo. Some time ago, there were updated to use multi-arch: knative/docs#5273

Unfortunately, only arm64,amd64 is configured:

https://github.com/knative/docs/blob/c522018a2474384778c970b3487778207105fe3e/.github/workflows/knative-docs-image.yaml#L40-L46

Worth adding that we should use ghcr.io/knative/helloworld-go instead of gcr.io/knative-samples/helloworld-go

[cardil]

See: knative/docs#5718

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.