-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve jobrunner wait code to retry on recoverable errors #45
Comments
/kind enhancement |
I think #68 is directly impacted by this. For visibility linking discussion which lead to opening this issue #42 (comment) |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
@dsimansk Do you think this issue should be part of the Stable release (GA) milestone? |
@cardil depends if we see too much intermittent failures in tests or in the "production" use. However, my original proposal was to use client-go lib that's probably better tested and covers more recoverable failures. |
Per PR discussion: https://github.com/knative-sandbox/kn-plugin-event/pull/42/files#r674008140
Let investigate the
RetryWatcher
fromclient-go
tools and knative/client waiting loop to introduce retry on error in the waiting loop.There are cases that may result in premature closing of
ResultChan
, that's caused by recoverable failure. Detecting such occasions and re-creatingwatcher
instance might be very desired.https://github.com/knative-sandbox/kn-plugin-event/blob/0e1fe36db37682a10548808563a38c7e5ac3814c/pkg/k8s/jobrunner.go#L68-L96
The text was updated successfully, but these errors were encountered: