-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration should not use env var but config-kourier
#877
Comments
This issue is stale because it has been open for 90 days with no |
This issue or pull request is stale because it has been open for 90 days with no activity. This bot triages issues and PRs according to the following rules:
You can:
/lifecycle stale |
/lifecycle frozen |
/good-first-issue |
The same would probably apply for |
I would like to contribute in this but I am an absolute beginner if anyone can help me by providing steps it would be nice |
Hmm... I think it is not a "good-first-issue" issue actually. It needs many steps for the change and one big concern is that some configurations might need to be loaded before ConfigMap informer's reconcile loop. |
Yeah, I think it could be more complicated than initially though. I haven't checked if any of the configs actually is affected by what you described. But it is probably better to start with a simpler issue @harshil1973. /remove-good-first-issue |
Currently some configurations especially external authorization use env variables as https://github.com/knative-sandbox/net-kourier#external-authorization-configuration instead of config-kourier configmap.
I think that there is no big reason for using env variable but we just used it because we haven't introduced
config-kourier
at that time.Now, since new configurations are added in
config-kourier
, the env variables should be migrated into the configmap.The text was updated successfully, but these errors were encountered: