Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

[question/feature request] Need to support tolerations in build spec? #483

Open
mathspanda opened this issue Nov 30, 2018 · 2 comments
Open
Labels

Comments

@mathspanda
Copy link
Contributor

mathspanda commented Nov 30, 2018

I have seen that NodeSelector and Affinity are supported in build spec. If i want pods to be deployed on dedicated nodes for build, i will try to use NodeSelector, while taints may be added to these dedicated nodes to ensure that other pods will not be scheduled onto them. So can we support tolerations?

Expected Behavior

Support tolerations in build spec.

Actual Behavior

Temporarily not support.

Additional Info

Another problem, the NodeSelector field in build spec is redundant, which can be replaced by Affinity.NodeAffinity.RequiredDuringSchedulingIgnoredDuringExecution.

As this k8s doc said:

nodeSelector continues to work as usual, but will eventually be deprecated, as node affinity can express everything that nodeSelector can express.

/kind question
/area api

@mathspanda
Copy link
Contributor Author

I'd be interested in working on this if need.

@mathspanda
Copy link
Contributor Author

/cc @shashwathi @imjasonh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants