Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[48h Knative] Color output #1891

Closed
4 tasks done
rhuss opened this issue Nov 16, 2023 · 4 comments
Closed
4 tasks done

[48h Knative] Color output #1891

rhuss opened this issue Nov 16, 2023 · 4 comments
Assignees
Labels
knative48h Issue selected for the "48h Knative" hackathon lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@rhuss
Copy link
Contributor

rhuss commented Nov 16, 2023

👋 Hello, awesome contributor!

Are you excited about Knative and open-source development? You're in the right place! This is a mini-project for the upcoming 48h Knative event—a 48-hour hackathon designed to boost contributions to the Knative Client project. For more details, check out Issue #1842.

🎯 Project Description

Colorify the output of kn.

This includes using emojis to indicate actions. See #1589 and #75 color for an early attempt, which is outdated for quite some time.

For proper layout and less work when implementing, it might be worth to consider introducing a color library like https://github.com/charmbracelet/lipgloss or something similar.

Color output should be optional, so always keep the existing layout when colors are switched off.

As a bonus (optional), think about possibly adding theme support to support dark and light backgrounds. Such themes might be possible to be defined in the configuration file.

🌟 Benefits

Having a modern UI is essential to stand out from other CLI tools, and event if it might not add to the functionality, it's more fun to work with a beautiful tool.

Using colors also adds an extra dimension to highlight important parts and to structure the output. There are just more possibilities to interact with the user.

🛠 Difficulty Level

Intermediate

👥 Recommended Team Size

1-2

🎉 Expected Outcome

Having some of kn outputs be colorized and developing a particular theme that can be worked on later. It is not expected that everything already has color output.

Coloring should be optional, and it should be possible to switch it off via a command line option (e.g. --color no or --no-color). There should also be an auto-detection whether a TTY is attached and if not, no color output should be used (e.g., when kn is used in pipes or scripts)

🤝 Mentor

📝 Additional Information

Some interesting libraries:

🌐 Entrypoints


📋 Organizer Checklist

  • Added to Project Board
  • Proposal Reviewed
  • Assigned a Mentor
  • Expected Outcome define
@rhuss rhuss converted this from a draft issue Nov 16, 2023
@rhuss rhuss added the knative48h Issue selected for the "48h Knative" hackathon label Nov 17, 2023
@rhuss rhuss self-assigned this Nov 23, 2023
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
@rhuss
Copy link
Contributor Author

rhuss commented Feb 22, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2024
@rhuss rhuss reopened this Jul 22, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2024
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knative48h Issue selected for the "48h Knative" hackathon lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
Status: Done
Development

No branches or pull requests

1 participant