Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link broken on tektoncd/operator/blob/main/DEVELOPMENT.md #1914

Open
T3-git opened this issue Dec 28, 2023 · 9 comments · May be fixed by Srish-ty/docs#1 or knative/docs#6151
Open

Link broken on tektoncd/operator/blob/main/DEVELOPMENT.md #1914

T3-git opened this issue Dec 28, 2023 · 9 comments · May be fixed by Srish-ty/docs#1 or knative/docs#6151
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@T3-git
Copy link

T3-git commented Dec 28, 2023 •
edited
Loading

Expected Behavior

On https://github.com/tektoncd/operator/blob/main/DEVELOPMENT.md when clicking the link in

To setup a cluster with GKE:

Install required tools and setup GCP project (You may find it useful to save the ID of the project in an environment variable (e.g. PROJECT_ID).

you will be lead to a file not found page.

Actual Behavior

This link should link to a markdown document describing Knative-with-GKE.md or if this document no longer exists, a replacement solution should be provided.

Steps to Reproduce the Problem

  1. Open DEVELOPMENT.md
  2. Click the link under to setup a cluster with GKE
@T3-git T3-git added the kind/bug Categorizes issue or PR as related to a bug. label Dec 28, 2023
@T3-git
Copy link
Author

T3-git commented Dec 28, 2023

/kind documentation
/good-first-issue

@tekton-robot
Copy link
Contributor

@T3-git:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind documentation
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 28, 2023
@SD-13
Copy link

SD-13 commented Dec 28, 2023

Did a little digging and looks like the doc was removed in knative/docs#2170

@professorabhay
Copy link

Do we have to remove that part?

@T3-git
Copy link
Author

T3-git commented Dec 30, 2023

Maybe I wasnt the best canidate to report this(I'm, also new). Seems like @SD-13 found thats its been moved to one large file if I read correctly so I would assume we would verify that section is still there and update the link accordingly. SD-13 might be working this though since they tracked down the commit.

@SD-13
Copy link

SD-13 commented Dec 30, 2023

I think we should replace the old link with this README if we don't want to refactor this doc.

@kumarankit999
Copy link

Yes, It would be great @SD-13!

@SD-13
Copy link

SD-13 commented Jan 1, 2024

I will open a PR for it!

@SD-13 SD-13 mentioned this issue Jan 1, 2024
Closed
4 tasks
This was referenced Oct 28, 2024
Open
Open
@Srish-ty
Copy link

@T3-git I've added PR linked with this issue:
knative/docs#6151
please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
6 participants
@tekton-robot @Srish-ty @professorabhay @T3-git @SD-13 @kumarankit999