Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestReply: Added feature flag for default timeout #8361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RequestReply: Added feature flag for default timeout #8361

wants to merge 1 commit into from
+44 −23

Conversation

AlexMamoukarys
Copy link

@AlexMamoukarys AlexMamoukarys commented Dec 1, 2024 •
edited
Loading

_

Fixes #8338

Proposed Changes

  • Add feature flag for default timeout on RequestReply resources
  • Use feature flag in webhook

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Made request reply timeout configurable through config-features

Docs

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 1, 2024 •
edited
Loading

CLA Signed

  • ✅login: AlexMamoukarys / (65929f1)

The committers listed above are authorized under a signed CLA.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlexMamoukarys
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2024

Welcome @AlexMamoukarys! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2024

Hi @AlexMamoukarys. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cali0707
Copy link
Member

Cali0707 commented Dec 1, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.23%. Comparing base (7176ce6) to head (65929f1).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/apis/feature/features.go 55.00% 9 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8361   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files         390      389    -1     
  Lines       23248    23291   +43     
=======================================
+ Hits        14934    14962   +28     
- Misses       7520     7535   +15     
  Partials      794      794

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2024

@AlexMamoukarys: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_main 65929f1 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr Awaiting requested review from creydr

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestReply: Configure Timeout Default in Feature Configmap
2 participants
@AlexMamoukarys @Cali0707