Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 🧹 Using scripts without relying on vendor dir #8056

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] 🧹 Using scripts without relying on vendor dir #8056

wants to merge 4 commits into from

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Jun 28, 2024

Tests knative/hack#386

Proposed Changes

  • 🧹 Using scripts without relying on vendor dir

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 28, 2024
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jun 28, 2024
cardil
cardil commented Jun 28, 2024
View reviewed changes
go.mod Outdated
@@ -50,6 +50,8 @@ require (
sigs.k8s.io/yaml v1.4.0
)

replace knative.dev/hack => github.com/cardil/knative-hack v0.0.0-20240627155243-4b5dad135546
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Remove this replace before merge

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (2cc0a5b) to head (f12b521).
Report is 66 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8056   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files         368      368           
  Lines       17551    17551           
=======================================
  Hits        11912    11912           
  Misses       4894     4894           
  Partials      745      745

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil cardil changed the title 🧹 Using scripts without relying on vendor dir [WIP] 🧹 Using scripts without relying on vendor dir Jun 28, 2024
@cardil
Copy link
Contributor Author

cardil commented Jul 2, 2024

/test build-test

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 2, 2024

@cardil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-tests
  • /test conformance-tests
  • /test reconciler-tests
  • /test unit-tests
  • /test upgrade-tests

Use /test all to run all jobs.

In response to this:

/test build-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Contributor Author

cardil commented Jul 2, 2024

/test build-tests

@cardil cardil force-pushed the chore/hack-scripts branch 2 times, most recently from 6128aa2 to 3e2dd6e Compare July 2, 2024 08:10
@cardil
Copy link
Contributor Author

cardil commented Jul 2, 2024

/test build-tests

@cardil cardil force-pushed the chore/hack-scripts branch 3 times, most recently from 033ddb8 to e91b630 Compare July 2, 2024 10:34
@cardil
Copy link
Contributor Author

cardil commented Jul 2, 2024

/test all

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 5, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@cardil
Copy link
Contributor Author

cardil commented Jul 9, 2024

/test all

@cardil cardil mentioned this pull request Jul 9, 2024
Merged
@cardil
Copy link
Contributor Author

cardil commented Jul 18, 2024

/test all

@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2024
@github-actions GitHub Actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@mgencur mgencur Awaiting requested review from mgencur

Assignees
No one assigned
Labels
area/test-and-release Test infrastructure, tests or release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cardil @knative-prow-robot