You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is quite noisy and adds a (soft) dependency on Dapr, which I would not add by default. It is confusing for people not using Dapr to see such annotations on their services unconditionally.
My proposal:
Make adding the dapr.io annotations optional and enable them only when a Dapr installation is detected or configured by the user.
Remove the boson.dev annotations, they are redundant
Remove function.knative.dev as it is redundant and adds some noise. You can always check for the existence of function.knative.dev/name like with kubectl get pods -l function.knative.dev/name. Removing that function.knative.dev annotation would avoid inconsistencies when it is set but the name is not (like when manually edited).
The text was updated successfully, but these errors were encountered:
When deploying a function, I get a KService with the following metadata:
This is quite noisy and adds a (soft) dependency on Dapr, which I would not add by default. It is confusing for people not using Dapr to see such annotations on their services unconditionally.
My proposal:
dapr.io
annotations optional and enable them only when a Dapr installation is detected or configured by the user.boson.dev
annotations, they are redundantfunction.knative.dev
as it is redundant and adds some noise. You can always check for the existence offunction.knative.dev/name
like withkubectl get pods -l function.knative.dev/name
. Removing thatfunction.knative.dev
annotation would avoid inconsistencies when it is set but thename
is not (like when manually edited).The text was updated successfully, but these errors were encountered: