-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] attempt pod addressability for the autoscaler #15388
base: main
Are you sure you want to change the base?
Conversation
* change private K8s service to be a headless service * use clusteripnone constant
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15388 +/- ##
==========================================
- Coverage 84.58% 84.56% -0.02%
==========================================
Files 219 219
Lines 13587 13587
==========================================
- Hits 11492 11490 -2
- Misses 1726 1728 +2
Partials 369 369 ☔ View full report in Codecov by Sentry. |
/test all |
/test ? |
@dprotaso: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test istio-latest-mesh |
@dprotaso: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Failed to probe clusterIP None:80 err=error roundtripping http://None:80/healthz: dial tcp: lookup None on 10.26.112.10:53: no such host |
Yeah passthrough isn't enabled on the tests. One thing though - I think we could do a headless service and do probing using the hostname instead of the cluster IP. I'll do a separate PR for that |
This Pull Request is stale because it has been open for 90 days with |
Changes