Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test/performance] round computed rate in real-traffic-test #15641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maschmid
Copy link
Contributor

real-traffic-test benchmark SLA 2 fails frequently just because the computed rate is not exactly the expected value , e.g. https://prow.knative.dev/view/gs/knative-prow/logs/performance-tests_serving_main_periodic/1862287597506662400

SLA 2 failed. vegeta rate is 2000.006921, expected Rate is 2000.000000

Let's do the same here as we already to in https://github.com/knative/serving/blob/main/test/performance/benchmarks/rollout-probe/main.go#L234 , and add tolerance to the rate comparison to fit within the nearest integer.

  • round computed Rate on real-traffic-test benchmark

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2024
Copy link

knative-prow bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maschmid
Once this PR has been reviewed and has the lgtm label, please assign salaboy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maschmid maschmid changed the title round computed rate in real-traffic-test [test/performance] round computed rate in real-traffic-test Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.53%. Comparing base (5717d19) to head (8eed01e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15641   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files         219      219           
  Lines       17427    17427           
=======================================
  Hits        14558    14558           
+ Misses       2498     2496    -2     
- Partials      371      373    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant