You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, many classes of rlpy3 have many mutable class variables like Domain.
Apparently, this is a bad manner because it means we cannot create multiple instances of the class.
Or, we have also many cases where we override the class variable in __init__. In these cases, class variables are redundant.
So we should fix it so that
All class variables are immutable
No override for class variables
Immutable class variables should be UPPER_SNAKE_CASE for noticeability
The text was updated successfully, but these errors were encountered:
kngwyu
changed the title
Mutable class variables
Mutable/Redundant class variables
Sep 30, 2019
Currently, many classes of rlpy3 have many mutable class variables like Domain.
Apparently, this is a bad manner because it means we cannot create multiple instances of the class.
Or, we have also many cases where we override the class variable in
__init__
. In these cases, class variables are redundant.So we should fix it so that
The text was updated successfully, but these errors were encountered: