Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to event page #32

Open
6 tasks
kav2k opened this issue May 12, 2014 · 4 comments
Open
6 tasks

Migrate to event page #32

kav2k opened this issue May 12, 2014 · 4 comments

Comments

@kav2k
Copy link
Collaborator

kav2k commented May 12, 2014

Work started by @Vinne2, currently in branch event-page, is aimed at replacing the persistent background page with an event one.

In principle, this is doable, but there are many effects to consider.

  • Finish transition of getCountersFromHTTP() to chrome.alarms
  • Test optimistic retry (Optimistic retry #22) with 1-minute granularity
  • Consider effects of transition for storage.js, i.e. state
  • Transition saveToStorage() to chrome.alarms (see syncRetryTimeout)
  • Consider top-level code in background.js
  • Consider ALL global state in functions.js

This is a non-trivial task, all in all, even not considering impact on #22.

@Kaligula0
Copy link

Any progress on that here?

Work must've pulled me away from this long ago and I totally forgot about the case. Now I've been checking my extensions and have just started filing issues about moving them to be persistent:false and came back to this. I fell like in a timeloop…

@kav2k
Copy link
Collaborator Author

kav2k commented May 14, 2020

Nope, no progress. I haven't touched this extension in years (because it works as-is).

@Kaligula0
Copy link

I'd like to make a pull request to the branch event-page here for you to see my work, but the branch is 4 years behind the master. Should you update the event-page branch from master or should I make a pull request anyway? See the problem: https://github.com/knyar/theoldreader-chrome/compare/event-page...Vinne2:event-page?expand=1 The diff gets cluttered with all the 4-years' commits.

@kav2k
Copy link
Collaborator Author

kav2k commented May 14, 2020

Disregard the event-page branch here (I'll delete it), PR off the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants