Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from localStorage — is not safe against browsing data wipe #63

Open
kav2k opened this issue Feb 25, 2018 · 0 comments
Open

Comments

@kav2k
Copy link
Collaborator

kav2k commented Feb 25, 2018

As a report shows, the preferences can get reset. Presumably, this is a result of "Site Data" wipe in Firefox.

As per MDN docs:

Although this API [browser.storage.local] is similar to Window.localStorage it is recommended that you don't use Window.localStorage in the extension code to store extension-related data. Firefox will clear data stored by extensions using the localStorage API in various scenarios where users clear their browsing history and data for privacy reasons, while data saved using the storage.local API will be correctly persisted in these scenarios.

A code performing a migration is needed.
Should also clean the mess from botched 1.5.1 upgrade (though it's harmless) and add storage versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant