Allow specification of the binary name/path #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some container usage expects to run an executable in a specific location, and some projects aren't well laid out to generate binaries with the expected names. This allows the binary name to be specified in configuration (in a similar way to goreleaser), which should allow for easier migration from other build mechanisms (and usage patterns of their images) to `ko`. This does not affect the name or path for Windows builds - the path structure is fundamentally different, and I think that if it's desirable to change the name/path for them, we should use a separate config argument.
|
This Pull Request is stale because it has been open for 90 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some container usage expects to run an executable in a specific location, and some projects aren't well laid out to generate binaries with the expected names.
This allows the binary name to be specified in configuration (in a similar way to goreleaser), which should allow for easier migration from other build mechanisms (and usage patterns of their images) to
ko.This does not affect the name or path for Windows builds - the path structure is fundamentally different, and I think that if it's desirable to change the name/path for them, we should use a separate config argument.
connects #944