Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YM2608 rhythm channel distortion #17

Open
mmontag opened this issue Oct 21, 2018 · 1 comment
Open

YM2608 rhythm channel distortion #17

mmontag opened this issue Oct 21, 2018 · 1 comment

Comments

@mmontag
Copy link

mmontag commented Oct 21, 2018

Hi @kode54 , I'm getting some severe distortion on the YM2608 rhythm channel (I think?).
Is this something you're able to reproduce?
I know these cores come from MAME.

see Grounseed tracks for example:
https://mmontag.github.io/chip-player-js/?q=grounseed&play=VGM+Rips/Grounseed_(NEC_PC-9801%2C_OPNA)/12+F.N.+%5BFive+Knights%5D.vgz

@mmontag
Copy link
Author

mmontag commented Oct 22, 2018

Looking into this a bit more, I believe it's just a 16 bit integer overflow clipping distortion, after summing all the SSG (psg) channels with the PCM and FM channels. Nothing to do with the ADPCM rhythm channels in particular.

YM2608 chip has 16 total channels so they need a lot of headroom to avoid clipping. I will have a look at the VGMPlay branch and try to find the appropriate gain levels for mixing all these channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant