Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos? #12

Open
MilhouseVH opened this issue Mar 29, 2016 · 2 comments
Open

Typos? #12

MilhouseVH opened this issue Mar 29, 2016 · 2 comments

Comments

@MilhouseVH
Copy link

Could of minors:

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L1 - should be asplib, not libsamplerate - it's a little confusing for us cmake noobs. :)

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L14 - why does this file have the prefix apslib and all the others are asplib? I'm assuming it's a typo, although the file does actually exist with the apslib prefix...

@MilhouseVH
Copy link
Author

@AchimTuran
Copy link
Member

@MilhouseVH
Sorry for the late response, but I didn't had the time to look deeper into it.

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L14 - why does this file have the prefix apslib and all the others are asplib? I'm assuming it's a typo, although the file does actually exist with the apslib prefix...

find_path(ASPLIB_INCLUDE_DIRS "apslib_BiquadFactory.h" should be find_path(ASPLIB_INCLUDE_DIRS " "Biquads/apslib_BiquadFactory.h". All files of asplib should have the prefix asplib.

https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L26 SAMPLERATE_FOUND
https://github.com/kodi-adsp/adsp.biquad.filters/blob/master/Findasplib.cmake#L1 - should be asplib, not libsamplerate - it's a little confusing for us cmake noobs. :)

Yeah you're right. It should be asplib and not libsamplerate. That was one of my first CMake files and I was so happy that it worked and I didn't improve the copy and paste comments ;-)

All of this will be fixed in the next release of asplib. Thanks for the hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants