Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection lost spam #14

Open
AlexHaxe opened this issue Jun 28, 2015 · 14 comments
Open

Connection lost spam #14

AlexHaxe opened this issue Jun 28, 2015 · 14 comments

Comments

@AlexHaxe
Copy link

I am using Kodi on a raspberry pi and my VDR does not run all the time. And in this case Kodi or VNSI client will tell me every x seconds that the connection failed.
Users do not need the information that yet another connection attempt failed. It is redundant and distracting, because it won't stop telling you about the failing connection even when you are watching something from a different source.

VNSI client should tell me once (on startup) that the connection failed and then shut up until the state changes. So unless VNSI client just started or had a connection and lost it, I don't want to see connection lost notifications.

@Jalle19
Copy link
Contributor

Jalle19 commented Jun 28, 2015

Check "do not show connection warnings" in Kodi's live TV settings.

@AlexHaxe
Copy link
Author

I am running openelec 5.0.8 (with Kodi 14.2) and there is no such option.

@AlexHaxe
Copy link
Author

Also: I do want information about a lost connection, but I do not want it every n seconds, especially if it's not true. How can a connection be lost, if there was no connection in the first place? That doesn't make sense.
The plugin should tell me there is no connection and then keep quiet until the connection was restablished and then breaks again. So if the server side crashes after a few seconds into a new connection or during handshake, then yes show me a notification so I can fix my VDR. But if it's clearly not there / not responding, then just don't bother telling me something I already know over and over again.

@FernetMenta
Copy link
Contributor

you have to distinguish between a lost connection and one that can't be established. if you get this message every couple of seconds, the problem is in some level lower than vnsi. vnsi triggers the message when the connection got lost. if the server is down the connection can't be established again. this should not trigger this message. maybe something got broken with moving platform lib.

@Jalle19
Copy link
Contributor

Jalle19 commented Jun 28, 2015

@AlexHaxe the option is there, maybe you need to change the setting visibility level?
@FernetMenta the addon shouldn't trigger notifications on its own, otherwise the option mentioned above won't work.

@FernetMenta
Copy link
Contributor

@Jalle19 the message you are talking about is a different story and not 100% appropriate here. note that vnsi has this mechanism since forever.

@Jalle19
Copy link
Contributor

Jalle19 commented Jun 28, 2015

Okay

@FernetMenta
Copy link
Contributor

I think I see the issue in vnsi. will try to provide a fix this evening

@AlexHaxe
Copy link
Author

@Jalle19 I jave tried multiple skins (apart from the default Confluence), non shows that setting, but I can see a hideconnectionlostwarning option in guisettings.xml. It says default is true but the actual value is false.
If I try to change the value, it gets reset to false after the next start of Kodi. Even if I kill the process. So maybe this is an openelec thing.

@FernetMenta
Copy link
Contributor

@Jalle19 @opdenkamp this is an issue in platform code:
https://github.com/Pulse-Eight/platform/blob/master/src/posix/os-socket.h#L324
connect returns true when it should return false.

@opdenkamp
Copy link
Contributor

see Pulse-Eight/platform@079eded
don't think that kodi has pulled this in yet, but I don't have time to do pull requests right now, sorry.

@FernetMenta
Copy link
Contributor

@wsnipex what needs to be done to get those patches?

@wsnipex
Copy link
Contributor

wsnipex commented Jul 16, 2015

@wsnipex
Copy link
Contributor

wsnipex commented Jul 16, 2015

oh, ubuntu packages will need a bump though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants