-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Support #3
Comments
Hi @thiagodp! I would love to. However, the limitation is in the terminal itself. The terminal has to support embedding images and as far as I know iTerm2 is the only one that currently does. |
I see... |
BTW, I just found an ascii art -based gif cli. |
Definitely lower-res than the real image, but here are some pure-JavaScript options for getting some version of the image in non-iTerm2 terminals:
More work, but would be cool. 😄 |
Also looks like image-to-ascii would be perfect for this (much higher res than just color blocks)... if it supported file streams or Buffers! |
@benwiley4000 Very interesting! Think I may have to switch progress-img's default fallback to image-to-ascii! |
@benwiley4000 I've been playing around with image-to-ascii and it does in fact support buffers right out of the box luckily. |
Good to hear! |
Great! |
@benwiley4000 @thiagodp The biggest thing stopping me from implementing this is that image-to-ascii relies on image-parser which requires GraphicsMagick to be installed on the user's system. Which means that if implemented and a user runs |
@kodie this one has no native dependencies. https://github.com/ajay-gandhi/asciify-image Like the other module, it claims it takes a string path but I think a Buffer will work since it relies on |
@benwiley4000 Unfortunately lwip doesn't support modern node versions quite yet :( EyalAr/lwip#297 |
Aaah. Also I'm realizing the "no native dependencies" is a lie since lwip has some. ETA: The only advantage I guess is that you don't need to count on the user to install anything manually, but it's still prone to issues when you change Node versions, as with all C++ bindings. |
@thiagodp @benwiley4000 I have made a pull request for asciify-image that would make it truly dependency-free so if that gets merged we'll be in business! |
Awesome! Looking forward to what comes next. |
@benwiley4000 @thiagodp Please install the new release (v1.0.2) and give it a try! |
Hi, @kodie , sorry for giving you feedback so late... Anyway, this was the result on Windows 10: The ascii appeared at once. |
@thiagodp No worries, thank you for the feedback. I will look into this. |
Git bash too :( |
Hi, are you planning to make
npm-gif
available for other OSes' terminals? Thanks!The text was updated successfully, but these errors were encountered: