From 4815e0020a2ca5d25b8494971a22f1c538b325c0 Mon Sep 17 00:00:00 2001
From: Eddie Kohler <ekohler@gmail.com>
Date: Sat, 9 Dec 2023 08:50:30 -0500
Subject: [PATCH] Don't put garbage in redirection URLs.

---
 src/pages/p_bulkassign.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/pages/p_bulkassign.php b/src/pages/p_bulkassign.php
index 169814f721..6d2e6308ff 100644
--- a/src/pages/p_bulkassign.php
+++ b/src/pages/p_bulkassign.php
@@ -188,7 +188,7 @@ function print() {
         // redirect if save cancelled
         if (isset($qreq->saveassignment)
             && isset($qreq->cancel)) {
-            unset($qreq->saveassignment);
+            unset($qreq->saveassignment, $qreq->p, $qreq->pap);
             $conf->redirect_self($qreq); // should not return
             return;
         }
@@ -199,6 +199,7 @@ function print() {
             && isset($qreq->data)
             && $qreq->assignment_size_estimate < 1000
             && $this->complete_assignment(null)) {
+            unset($qreq->saveassignment, $qreq->p, $qreq->pap);
             $conf->redirect_self($qreq);
             return;
         }