Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a loop constraint doesn't lead to corresponding fix to the map #24

Open
abhi5691 opened this issue May 31, 2020 · 4 comments
Open

Comments

@abhi5691
Copy link

abhi5691 commented May 31, 2020

Hello,
Thanks for creating this fabulous tool.

I am trying to fix a map I generated using hdl_graph_slam for a nearly 1.2 km x 0.7 km loop. The generated map had major aberrations along the z-axis, as also some deficiencies in xy plane.

I have used interactive_slam for some maps in past. Often, adding manual loop constraints shows significant fixes in the map. However at times, it simply adds an additional edge between the selected nodes while leaving them where they were (and hence the map stays as before: erratic) or sometimes just moving them partially.

I am sure there is a constraint conflicting the new loop addition, but a clearer idea might help me fix the map better.

trackmap
This is the loop I want to map!

@abhi5691
Copy link
Author

int_map

As visible, the long edge at top center is unintentional, the nodes are supposed to be close together, and were so constrained manually.

@koide3
Copy link
Owner

koide3 commented Jun 1, 2020

Hi @abhi5691 ,
This behavior is caused by the robust kernel that prevents to largely change the estimate of the pose graph. Possible solutions are:

  • choose "NONE" kernel when inserting a loop edge so that the edge will not be ignored
  • perform graph optimization multiple times (Main menu -> Graph -> Optimize)

@koide3
Copy link
Owner

koide3 commented Jun 5, 2020

I found that a recent update introduced a bug that disables pose graph optimization after manual loop closing. I fixed this bug and pushed an updated code that will be merged soon.

@oscarmendezm
Copy link

This is also happening to me, even with the updated version. It seems to have something to do with floor constraints, as removing these makes the map immediately snap to the manual loop closure. Not sure what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants