New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed partial specialization of Barrier for MPI #123

Open

cwpearson opened this issue Sep 12, 2024 · 0 comments

Collaborator

cwpearson commented Sep 12, 2024 •

edited

Loading

kokkos-comm/src/KokkosComm/mpi/barrier.hpp

Lines 24 to 30 in a968a13

    
           template <KokkosExecutionSpace ExecSpace, CommunicationSpace CommSpace> 
        
           struct Barrier { 
        
             Barrier(Handle<ExecSpace, Mpi> &&h) { 
        
               h.space().fence("KokkosComm::Impl::Barrier"); 
        
               MPI_Barrier(h.mpi_comm()); 
        
             } 
        
           };

This should be something like

template <KokkosExecutionSpace ExecSpace, Mpi>
struct Barrier {
  Barrier(Handle<ExecSpace, Mpi> &&h) {
    h.space().fence("KokkosComm::Impl::Barrier");
    MPI_Barrier(h.mpi_comm());
  }
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment