Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if kernel/fence does not have a name #18

Open
DavidPoliakoff opened this issue Aug 11, 2020 · 0 comments
Open

Warn if kernel/fence does not have a name #18

DavidPoliakoff opened this issue Aug 11, 2020 · 0 comments

Comments

@DavidPoliakoff
Copy link

This one shouldn't be too bad, something to the effect of

match callExpr(callee(functionDecl(namedDecl(matchesName("name_we_care_about")))),unless(hasAnyArgument(isStringish)))

Or I guess you could match the types of the parameters

match callExpr(callee(functionDecl(namedDecl(matchesName("name_we_care_about")),unless(hasAnyParameter(isStringish)))))

Guarantee that within Kokkos we name all of our kernels and fences
@DavidPoliakoff DavidPoliakoff changed the title For testing: unnamed kernels (or soon, fences) For Kokkos itself: unnamed kernels (or soon, fences) Aug 11, 2020
@calewis calewis changed the title For Kokkos itself: unnamed kernels (or soon, fences) Warn if kernel/fence does not have a name Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidPoliakoff