feat(RELEASE-1327): add pipeline field to InternalRequests #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a Pipeline field to the InternalRequest Spec. This allows passing a pipeline using any kind of resolver, whereas the existing request field only allows for a cluster pipeline to be used. It also updates the manager to use this pipeline field and adds helper functions. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
release1327
branch
from
2a7bd33 to
efffc3d
Compare
mmalina
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a Pipeline field to the InternalRequest Spec. This allows passing a pipeline using any kind of resolver, whereas the existing request field only allows for a cluster pipeline to be used.
It also updates the manager to use this pipeline field and adds helper functions.
One thing to note is that this is temporary - the plan is to remove the request method of calling a pipeline in an InternalRequest (in favor of a cluster resolver) so the code is written in a way that is not the most elegant, but should make it easy to remove the old stuff after