Skip to content

Commit

Permalink
refactor: use multiple source for kubernetes-dashboard argo application
Browse files Browse the repository at this point in the history
- store override in a separate values.yaml file
- upgrade to version 7.9.0
  • Loading branch information
muse-sisay committed Oct 29, 2024
1 parent aca1dbd commit 49b24a8
Show file tree
Hide file tree
Showing 6 changed files with 41 additions and 60 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,19 @@ metadata:
- resources-finalizer.argocd.argoproj.io
spec:
project: <PROJECT>
source:
sources:
repoURL: 'https://kubernetes.github.io/dashboard'
targetRevision: 6.0.0
targetRevision: 7.9.0
chart: kubernetes-dashboard
helm:
values: |
app:
ingress:
hosts:
# keep only the 'localhost' host if you only want to access Dashboard using 'kubectl port-forward ...' on:
# https://localhost:8443
# please note that the ingress itself is managed in ingress.yaml
- localhost
- kubernetes-dashboard.<DOMAIN_NAME>
helm:

Check failure on line 18 in kubernetes-dashboard/components/kubernetes-dashboard/application.yaml

View workflow job for this annotation

GitHub Actions / yaml-check

18:11 syntax error: mapping values are not allowed here (syntax)
valueFiles:
- $values/registry/clusters/<CLUSTER_NAME>/components/kubernetes-dashboard/values.yaml
- repoURL: <GITOPS_REPO_URL>
targetRevision: HEAD
ref: values
- repoURL: <GITOPS_REPO_URL>
path: registry/clusters/<CLUSTER_NAME>/components/kubernetes-dashboard/dependencies/
targetRevision: HEAD
destination:
name: <CLUSTER_DESTINATION>
namespace: kubernetes-dashboard
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: k8s-dashboard-clusterrole
name: dashboard-user
annotations:
argocd.argoproj.io/sync-wave: "0"
subjects:
- kind: ServiceAccount
name: <CLUSTER_NAME>-kubernetes-dashboard
namespace: kubernetes-dashboard
roleRef:
kind: ClusterRole
name: admin
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: cluster-admin
subjects:
- kind: ServiceAccount

Check failure on line 13 in kubernetes-dashboard/components/kubernetes-dashboard/dependencies/clusterolebinding.yaml

View workflow job for this annotation

GitHub Actions / yaml-check

13:1 [indentation] wrong indentation: expected 2 but found 0
name: dashboard-user
namespace: kubernetes-dashboard
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
apiVersion: v1
kind: ServiceAccount
metadata:
name: dashboard-user

# to get your bearer token for auth, connect to your cluster, then run command:
# kubectl -n kubernetes-dashboard create token dashboard-user
27 changes: 0 additions & 27 deletions kubernetes-dashboard/components/kubernetes-dashboard/ingress.yaml

This file was deleted.

This file was deleted.

14 changes: 14 additions & 0 deletions kubernetes-dashboard/components/kubernetes-dashboard/values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
app:

Check warning on line 1 in kubernetes-dashboard/components/kubernetes-dashboard/values.yaml

View workflow job for this annotation

GitHub Actions / yaml-check

1:1 [document-start] missing document start "---"

Check failure on line 1 in kubernetes-dashboard/components/kubernetes-dashboard/values.yaml

View workflow job for this annotation

GitHub Actions / yaml-check

1:5 [trailing-spaces] trailing spaces
ingress:
enabled: true
hosts:
- kubernetes-dashboard.<CLUSTER_NAME>.<DOMAIN_NAME>
ingressClassName: nginx
tls:
enabled: true
secretName: "kubernetes-dashboard-tls"
issuer:
scope: cluster
name: "letsencrypt-prod"
annotations:
argocd.argoproj.io/sync-wave: "2"

Check failure on line 14 in kubernetes-dashboard/components/kubernetes-dashboard/values.yaml

View workflow job for this annotation

GitHub Actions / yaml-check

14:40 [new-line-at-end-of-file] no new line character at the end of file

0 comments on commit 49b24a8

Please sign in to comment.