Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a note about testing ourselves since it's complicated #39

Merged
merged 3 commits into from
Nov 15, 2023
Merged

docs: add a note about testing ourselves since it's complicated #39

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70c1fb6
docs: add a note about testing ourselves since it's complicated
fharper Nov 15, 2023
4ff24b2
Merge branch 'main' into fharper/testing
fharper Nov 15, 2023
73b80fd
fix Markdown
fharper Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

## Contributing


Check failure on line 15 in README.md

View workflow job for this annotation

GitHub Actions / markdown-check

Multiple consecutive blank lines 

README.md:15 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.31.1/doc/md012.md

Check failure on line 16 in README.md

View workflow job for this annotation

GitHub Actions / markdown-check

Multiple consecutive blank lines 

README.md:16 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 3] https://github.com/DavidAnson/markdownlint/blob/v0.31.1/doc/md012.md
To make a new application available for installation, you'll need to:

- Fork this repository.
Expand Down Expand Up @@ -47,7 +49,7 @@

### Testing

If you want to test the application you are adding to the catalog, you need to run a couple of things locally.
If you want to test the application you are adding to the catalog, you need to run a couple of things locally. The process is a bit complicated, so feel free to submit a pull request without all the local tests, and we'll happily do the testing for you. If you want to proceed by yourself, follow these steps.

Firstly, if it's not already done, you need to [create a fork](https://github.com/kubefirst/kubefirst-api/fork) of the gitops-catalog repository.

Expand All @@ -73,4 +75,4 @@

### Need Help

As always, we are on our [Slack community](https://kubefirst.io/slack) in the #gitops-catalog channel if you need any help. We also welcome any constructive feedback or feature suggestions.
As always, we are on our [Slack community](https://kubefirst.io/slack) in the #gitops-catalog channel if you need any help. We also welcome any constructive feedback, feature or application suggestions.
Loading