Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Cleanup node labels casting while matching a reservation affinity #2208

Open
saintube opened this issue Sep 18, 2024 · 0 comments
Labels
area/koord-scheduler kind/proposal Create a report to help us improve
Milestone

Comments

@saintube
Copy link
Member

What is your proposal:

When a pod specifies the reservation affinity with a label selector, the candidate reservations will inherit the labels of their nodes before doing the match. It is helpful when the pod wants to select the reservation according to some node-level attributes, e.g. node.kubernetes.io/zone. However, it corrupts the label selector of the reservations themselves. When a pod wants to affinity according to a reservation label instead of the same label on the node, it can not work.

In this proposal, we want to clean up the label casting logic for the reservation from the node labels. However, some special labels like the node.kubernetes.io/zone should be optional to keep. Perhaps we need to add fields in the ReservationArgs.

Why is this needed:

Is there a suggested solution, if so, please add it:

@saintube saintube added area/koord-scheduler kind/proposal Create a report to help us improve labels Sep 18, 2024
@songtao98 songtao98 modified the milestones: someday, v1.6 Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/koord-scheduler kind/proposal Create a report to help us improve
Projects
None yet
Development

No branches or pull requests

2 participants