Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add John Wick Award badge #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add John Wick Award badge #46

wants to merge 3 commits into from

Conversation

kostrykin
Copy link
Contributor

@kostrykin kostrykin commented Jan 3, 2025

Fix #26


For more details, open the Copilot Workspace session.

Copy link
Contributor Author

@kostrykin kostrykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining tasks

django/stats/models.py Outdated Show resolved Hide resolved
django/stats/models.py Show resolved Hide resolved
@@ -83,6 +83,12 @@
<div class="legend-item-description">Be the red lantern of your team with <span class="nowrap">K/D &leq;0.5</span>, <span class="nowrap">ADR &leq;50</span>, and a substantial deficit in ADR.</div>
</div>

<div class="legend-item">
<div style="background-image: url('{% static 'badges' %}/john-wick-award.png');" class="badge"></div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the missing image file john-wick-award.png

django/stats/templates/stats/squads.html Outdated Show resolved Hide resolved
* **Models**: Add "John Wick Award" badge type to `MatchBadgeType` and implement logic to award the badge in `MatchBadge`.
* **Views**: Update badge display logic in `get_badges` to include "John Wick Award".
* **Templates**: Update badge display templates in `player.html`, `squads.html`, `profile-card.html`, `sessions.html`, and `sessions-list.html` to include "John Wick Award".
* **Tests**: Add tests for "John Wick Award" badge in `MatchBadge__award`.
* **Migrations**: Create migration file to add "John Wick Award" badge type to `MatchBadgeType`.
Copy link

github-actions bot commented Jan 3, 2025

Test coverage of c237e35: 72%

Copy link

github-actions bot commented Jan 3, 2025

Test coverage of 4eb55e1: 72%

@kostrykin kostrykin requested a review from Copilot January 3, 2025 19:12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • django/stats/templates/stats/squads.html: Language not supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more badges
1 participant