Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider an API more in line with the Rust API guidelines #2

Open
quodlibetor opened this issue Oct 9, 2017 · 6 comments
Open

Consider an API more in line with the Rust API guidelines #2

quodlibetor opened this issue Oct 9, 2017 · 6 comments

Comments

@quodlibetor
Copy link

Your API imitates Chrono's (which makes sense) with constructors like ::days(), but it's much more common in rust to have names like ::from_days() for static constructors.

Chrono is pretty old, and contains some styles that are unexpected to modern Rust programmers. I hope to migrate chrono to something that will cause less confusion for our users.

@kosta
Copy link
Owner

kosta commented Oct 9, 2017

Makes sense. I did not think much, about this. I just copied what's in chrono :)

@quodlibetor
Copy link
Author

Yup, like I said what you did makes sense, it's just unfortunate that chrono's api is so unrusty.

@mayurdzk
Copy link

mayurdzk commented Aug 1, 2018

Hey @kosta I just came across this project and it's been helpful for me in my work. Are you still working to maintain it? Will you be open to PRs to your repository?

(Apologies for communicating over an issue, I couldn't find any other place to get in touch with you.)

@kosta
Copy link
Owner

kosta commented Aug 1, 2018 via email

@mayurdzk
Copy link

mayurdzk commented Aug 2, 2018

@kosta Thanks for writing in. Yes, I saw the issues on this repo and that you wanted to change the API to match Rust styling.

This is why I was hoping I could contribute to the repository if you'd like. Let me know if this is something you might be interested in.

Thanks for your time! 😃

@kosta
Copy link
Owner

kosta commented Aug 22, 2018

@mayurdzk I'm currently experimenting with a better code structure and need to figure out if this works. When I have a prototype I would appreciate your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants