Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing and catching ClassNotFoundException for SubList and RandomAccessSubList #111

Open
sfc-gh-dschumann opened this issue Sep 21, 2021 · 0 comments

Comments

@sfc-gh-dschumann
Copy link

As these Classes don't exist anymore in newer Java versions, lines 115 and 116 in src/main/java/com/rits/cloning/Cloner.java always cause an exception to be thrown and caught.
As exceptions are less efficient than regular code executions this should be avoided from a performance perspective.
If the maintainers agree I could open a PR with an added java version check at that point in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant