-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't input none-english characters using VisText #277
Comments
I have figured it out. See this pull request. #278 |
Although this is a real problem, because VisUI uses prerendered bitmap font and cannot display glyphs like Chinese, I think this solution should be kept outside of the library. But I see your issue mostly addressed the VisEditor (which I personally don't use), rather then VisUI library, so this could be a really important topic you raised. But since it breaks underlying independent widget library, unfortunately, I can't agree with the solution. @dotw probably you can go with another approach that is just localized inside VisEditor and does not add FreeTypeFont dependency to the VisUI? I've actually came across the same problem with VisUI some time ago and solved it by injecting lazy generating FreeTypeFont into the skin, check this out: |
Great response from @metaphore. FreeType dependency can't be added to VisUI because we need to support GWT. VisEditor was deprecated, I'm not accepting any PRs for it. That's why it's disabled in I like the solution of injecting FreeTypeFont into the skin most. It's not really hard to do from library user code but it might be a good candidate for vis-ui-contrib as a helper method of some kind. |
@metaphore Use image to replace the font is not acceptable. Not like english characters. English has only 26 characters, but Chinese are thousands. It's not acceptable to combine these characters in png files. Think about how large the png file will be. |
@dotw looks like you get me completely wrong, please reread my message. |
@metaphore, i'm so sorry. i didn't realize bring free type into VisUI. thanks for your reminder again. |
I can't change the text from English character to none-English characters when drag a VisText component from ttf font. Can you guide me which class is controlling this? I want to enhance this to support Chinese characters. Thanks.
The text was updated successfully, but these errors were encountered: